Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetMandatoryResult operations return nonnull result #883

Merged
merged 1 commit into from Jan 4, 2018

Conversation

nikitin-da
Copy link
Collaborator

Fix #863 for get operations

@nikitin-da nikitin-da added the bug label Jan 1, 2018
@nikitin-da nikitin-da added this to the v3.0.1 milestone Jan 1, 2018
@nikitin-da nikitin-da self-assigned this Jan 1, 2018
@codecov-io
Copy link

codecov-io commented Jan 1, 2018

Codecov Report

Merging #883 into master will decrease coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #883      +/-   ##
============================================
- Coverage     98.06%   97.99%   -0.08%     
+ Complexity      827      815      -12     
============================================
  Files            99       98       -1     
  Lines          2889     2787     -102     
  Branches        321      308      -13     
============================================
- Hits           2833     2731     -102     
  Misses           27       27              
  Partials         29       29
Impacted Files Coverage Δ Complexity Δ
...esh/storio3/sqlite/operations/get/PreparedGet.java 100% <ø> (ø) 6 <0> (ø) ⬇️
...o3/contentresolver/operations/get/PreparedGet.java 100% <ø> (ø) 3 <0> (ø) ⬇️
...ite/operations/get/PreparedGetMandatoryResult.java 100% <100%> (ø) 3 <1> (ø) ⬇️
...orio3/sqlite/operations/get/PreparedGetObject.java 100% <100%> (ø) 7 <1> (-4) ⬇️
...ver/operations/get/PreparedGetMandatoryResult.java 100% <100%> (ø) 2 <1> (ø) ⬇️
...tentresolver/operations/get/PreparedGetObject.java 100% <100%> (ø) 6 <1> (-4) ⬇️
...h/storio3/sqlite/interop1to3/StorIOSQLite1To3.java

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e65a48e...5a2bd2c. Read the comment docs.

@nikitin-da nikitin-da force-pushed the get-operations-nullability-fix branch from e9bc7d1 to d50be46 Compare January 3, 2018 13:41
@nikitin-da nikitin-da force-pushed the get-operations-nullability-fix branch from d50be46 to 5a2bd2c Compare January 3, 2018 13:42
@geralt-encore geralt-encore merged commit 01b9b8d into master Jan 4, 2018
@geralt-encore geralt-encore deleted the get-operations-nullability-fix branch January 4, 2018 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants