Fix error when element ID is null

putyourlightson · Dec 13, 2023 · cf4b300 · cf4b300
1 parent 38ac255
commit cf4b300
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,11 @@
 # Release Notes for Blitz
 
+## 4.9.4 - Unreleased
+
+### Fixed
+
+- Fixed a bug that could cause an error when an element’s ID is unset ([#594](https://github.com/putyourlightson/craft-blitz/issues/594)).
+
 ## 4.9.3 - 2023-11-28
 
 ### Changed
@@ -11,7 +17,7 @@
 ### Changed
 
 - Integrity constraint violation exceptions are now caught when batch inserting rows into the database ([#588](https://github.com/putyourlightson/craft-blitz/issues/588)).
-- Reverted sending site URIs to the refresh cache event ([#590](https://github.com/putyourlightson/craft-blitz/issues/590)). 
+- Reverted sending site URIs to the refresh cache event ([#590](https://github.com/putyourlightson/craft-blitz/issues/590)).
 
 ### Fixed
 

diff --git a/composer.json b/composer.json
@@ -1,7 +1,7 @@
 {
   "name": "putyourlightson/craft-blitz",
   "description": "Intelligent static page caching for creating lightning-fast sites.",
-  "version": "4.9.3",
+  "version": "4.9.4",
   "type": "craft-plugin",
   "homepage": "https://putyourlightson.com/plugins/blitz",
   "license": "proprietary",

diff --git a/src/models/GenerateDataModel.php b/src/models/GenerateDataModel.php
@@ -103,6 +103,10 @@ public function addElementIds(array $elementIds): void
 
     public function addElement(ElementInterface $element): void
     {
+        if ($element->id === null) {
+            return;
+        }
+
         $this->addElementId($element->id);
     }