New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include base site URL #563

Closed

Romanavr wants to merge 1 commit into putyourlightson:develop from Romanavr:Fix-include-dynamic-URL

Romanavr commented Sep 26, 2023 •

edited

This is one of the possible solutions for #562
So the URL will look like:
https://site.com/en/?action=blitz/include/dynamic&index=XXXXXXXXX

Didn't test it with ESI/SSI

Additionally, one possible solution is to change the suggested URL to
$uri = $this->_getActionUrl($action); then string $uriPrefix will be not needed. I don't know how this might affect functionality for other part of the plugin.


          Include base site URL

a5c4904

sonarcloud bot commented Sep 26, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

Collaborator

bencroker commented Sep 26, 2023

Thanks for the suggestion but this breaks other parts of the system.

bencroker closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment