Fixed contact first/last name fields did not exist

CHANGELOG.md

@@ -2,6 +2,7 @@
 
 ## 1.18.3 - Unreleased
 ### Fixed
+- Fixed a bug in which an error was thrown when saving a user and contact first/last name fields did not exist ([#214](https://github.com/putyourlightson/craft-campaign/issues/214)).
 - Fixed the day of the month checkbox labels for values over 29.
 
 ## 1.18.2 - 2021-02-10

src/services/SyncService.php

@@ -174,20 +174,15 @@ public function syncUserMailingList(User $user, MailingListElement $mailingList)
         $contact->userId = $user->id;
         $contact->email = $user->email;
 
-        // Set first and last name from user fields if they exist
+        // Set first and last name from user fields only if they exist
         if (isset($contact->firstName)) {
-            $contact->firstName = $user->firstName;
+            $contact->setFieldValue('firstName', $user->firstName);
         }
         if (isset($contact->lastName)) {
-            $contact->lastName = $user->lastName;
+            $contact->setFieldValue('lastName', $user->lastName);
         }
 
-        $fieldValues = array_merge($user->getFieldValues(), [
-            'firstName' => $user->firstName,
-            'lastName' => $user->lastName,
-        ]);
-
-        $contact->setFieldValues($fieldValues);
+        $contact->setFieldValues($user->getFieldValues());
 
         if (!Craft::$app->getElements()->saveElement($contact)) {
             return;