Added missing anonymous tracking condition

putyourlightson · Mar 14, 2022 · 282332e · 282332e
1 parent 2585708
commit 282332e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/src/elements/CampaignElement.php b/src/elements/CampaignElement.php
@@ -649,7 +649,7 @@ public function getStatus(): ?string
      */
     public function hasRevisions(): bool
     {
-        return $this->getCampaignType()->enableVersioning;
+        return true;
     }
 
     /**

diff --git a/src/services/CampaignsService.php b/src/services/CampaignsService.php
@@ -43,7 +43,10 @@ public function addContactInteraction(ContactElement $contact, SendoutElement $s
         }
 
         /** @var CampaignRecord|null $campaignRecord */
-        $campaignRecord = CampaignRecord::findOne($sendout->campaignId);
+        $campaignRecord = CampaignRecord::find()
+            ->where(['id' => $sendout->campaignId])
+            ->with('campaignType')
+            ->one();
 
         if ($campaignRecord === null) {
             return;
@@ -103,7 +106,10 @@ public function addContactInteraction(ContactElement $contact, SendoutElement $s
             }
         }
 
-        $contactCampaignRecord->save();
+        // Only save is anonymous tracking is not enabled
+        if ($campaignRecord->campaignType->enableAnonymousTracking === false) {
+            $contactCampaignRecord->save();
+        }
 
         $campaignRecord->save();
     }