Fixed the unsubscribe webhook action

putyourlightson · Oct 28, 2022 · dbd2f78 · dbd2f78
1 parent bf2335f
commit dbd2f78
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Release Notes for Campaign
 
+## 2.1.17 - 2022-10-28
+### Fixed
+- Fixed a bug in which the unsubscribe webhook action could throw an exception ([#339](https://github.com/putyourlightson/craft-campaign/issues/339)).
+
 ## 2.1.16 - 2022-10-27
 ### Fixed
 - Fixed all remaining uninitialized typed properties, as a precaution.

diff --git a/composer.json b/composer.json
@@ -1,7 +1,7 @@
 {
     "name": "putyourlightson/craft-campaign",
     "description": "Send and manage email campaigns, contacts and mailing lists.",
-    "version": "2.1.16",
+    "version": "2.1.17",
     "type": "craft-plugin",
     "homepage": "https://putyourlightson.com/plugins/campaign",
     "license": "proprietary",

diff --git a/src/services/WebhookService.php b/src/services/WebhookService.php
@@ -72,10 +72,9 @@ private function _addInteraction(ContactElement $contact, string $interaction):
             }
         }
 
-        // Update contact
-        if (empty($contact->{$interaction})) {
+        // Update contact if the interaction exists on it
+        if (property_exists($contact, $interaction) && empty($contact->{$interaction})) {
             $contact->{$interaction} = new DateTime();
-
             Craft::$app->getElements()->saveElement($contact);
         }
     }