fix: fastify v3 compatibility #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting this PR! I'll leave it in "waiting for review" state until Fastify v3 is released. Once this happens, it would make sense to have tests for both v2 and v3. |
|
@SimenB as Fastify v3 is now released, we can proceed with this PR. Could you update tests, so that they run against Fastify v2 and v3? It should be similar to how it's done for koa v1, but we can reuse the same test script as in case of Fastify the API is the same. It would be also nice to update documentation, so it mentions both v2 and v3. |
|
@puzpuzpuz updated. I removed the |
SimenB
commented
Aug 19, 2020
puzpuzpuz
approved these changes
Aug 20, 2020
Co-authored-by: Andrey Pechkurov <37772591+puzpuzpuz@users.noreply.github.com>
|
@SimenB many thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #35. Not including the test change that issue mentions as v3 is not stable yet, but I think this should work for both v2 and v3. I can confirm it works for v3 RC 4 (latest as of time of writing)