Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle httpbin as string instead of list #130

Merged
merged 1 commit into from
Feb 9, 2020
Merged

Conversation

pv8
Copy link
Owner

@pv8 pv8 commented Feb 9, 2020

Revert back to the previous HTTPBIN response:

{
   "origin": "99.230.249.72"
}

@pv8 pv8 added the enhancement label Feb 9, 2020
@pv8 pv8 self-assigned this Feb 9, 2020
@codecov-io
Copy link

codecov-io commented Feb 9, 2020

Codecov Report

Merging #130 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #130   +/-   ##
=======================================
  Coverage   94.35%   94.35%           
=======================================
  Files           5        5           
  Lines         248      248           
  Branches       21       21           
=======================================
  Hits          234      234           
  Misses         12       12           
  Partials        2        2
Impacted Files Coverage Δ
noipy/utils.py 95% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59e35e3...b45ea02. Read the comment docs.

@pv8 pv8 merged commit 91a8b5b into master Feb 9, 2020
@pv8 pv8 deleted the fix-httpbin-response branch February 9, 2020 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants