Step branch #1
Merged
Step branch #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…0 or nonzero, which translates to falsy, which suffices for us. so we can always assign it rather than conditionally
…ed the vx/vy update such that we can immediately store it to pixel.
…happen afterwards. the first loop will simply say `undefined>0&undefined<M` is 0.
…t. now it makes sense for the next move
…of pixels for performance. though the +6 hurts for adding 10 of which 5 or 6 should be regpacked away. but oh. well.
…ing. so much hidden potential there
…the vars in `X=Y=i=q` to `B=C=N=O=F`, and adding that dud `F` so regpack finds the dupe in the element string at no additional cost. maybe we can use the `F` somehow later
…anything but probably wont hurt either). changed PSCl to mimic the element string as well. saves 4.
…oring warning in my ide :p nonsens but the change doesnt change anything and i cant find a use for that unused zero (or its space in general) so this is fine.
…ositional compensation is too awkward. but its fine for vert centering, we dont need that.
…anyways. saves one byte
…and 2 rather than 0. i am kind of worried that this may lead to errors but it seems to be ok
…ng that with `Uu`, we can safely check for `u` and prepend a `U`. so only prepending one character having no other downsides AND we dont need to take the second character from the match meaning we can drop the `[1]` as well. 2 left.
…and replace those `h=0 h=1 h=1` with `h++`, especially since it was already getting initialized by an arbitrary number, which means the increment of `h` was part of those identical `fillText` calls. hot digity, now all thats left is tweaking the numbers
…this should give me that space.
… function from a declaration into an expression. but of course assigning to `N`, which we only need to have been declared before reading it, suffices for this. _now_ we are ready for the fix which brings us back up to 1024
… was caused by the loop variable being assigned `1` or `-1` depending on the outcome of the affected line. this problem isnt very apparent with the current pixel sizes (though still present) but will be now that we will tweak the numbers a bit
…he roulette decides to work in my favor and give me free byte bonus. joy.
…=function` hack did not work (and i did not test it, or screwed up the test). the `N` binding is only created after the function is invoked, which is too late. oops. anywyas, confirmed that the minified build works now :)
…y to find a byte to be able to fix this bug that nobody would ever notice anyways. but the element number wasnt bound so when the elements would loop, the counter would keep going up. Of course, `%118` is four characters more than i had. Solved it by moving the `match` to the cycle loop. Not happy but perf seems okay on it so meh.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use this PR to step through the commits. Github won't otherwise create the prev/next links.