Skip to content
This repository has been archived by the owner on Aug 2, 2019. It is now read-only.

Adding buttons for fitting and rotating page #40

Merged
merged 4 commits into from
Jul 17, 2015
Merged

Adding buttons for fitting and rotating page #40

merged 4 commits into from
Jul 17, 2015

Conversation

bryjamus
Copy link
Contributor

I add buttons to toolbar which are responsible for fitting and rotating page. Fitting page is made by one of tree states:

  1. Fit width
  2. Fit height
  3. Fit best - which use one of above two states depending on control and document scale factor (look at method CalculateZoomMode in PdfRenderer.cs).

@bryjamus
Copy link
Contributor Author

If changes are ok with you please make new Nuget version after merge.

@bryjamus
Copy link
Contributor Author

One more think which you should know:

  • fit_xxx.png are downloaded from IconArchive and are on LGPL License
  • rotate_xxx.png are downloaded from IconArchive and are on CC Attribution 4.0 License

@pvginkel
Copy link
Owner

Thank you for your pull request. However, the changes to the toolbar should not be added to the project. I know this is a bit confusing to people, and I should really document the reason for this and how you can work around this. I've just now created an issue for this at #41. Please have a look at that for an explanation.

I do however like the best fit change. If it is possible for you to remove the changes to the PdfViewer control, I'm happy to accept the pull request. Sorry for the confusion.

@bryjamus
Copy link
Contributor Author

I revert changes and implemented only "Fit Best" in PdfRenderer class.

As I understand as you release new version we should use PdfRenderer instead PdfViewer and make our own toolbar for this control?

pvginkel added a commit that referenced this pull request Jul 17, 2015
Adding buttons for fitting and rotating page
@pvginkel pvginkel merged commit b050771 into pvginkel:master Jul 17, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants