-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe and update identity provider #146
Conversation
please fix black |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late review, but I noticed a potential issue with this PR. @pvizeli @idoseemplicity
Updates an existing identity provider | ||
:param pool_id: The user pool ID | ||
:param provider_name: The identity provider name | ||
:return: dict of identity provider |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method doesn't actually seem to return anything?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, this was already fixed with PR #148
@@ -866,6 +866,30 @@ def admin_create_identity_provider( | |||
**kwargs, | |||
) | |||
|
|||
def admin_describe_identity_provider(self, pool_id, provider_name): | |||
""" | |||
Updates an existing identity provider |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the describe method, right?
No description provided.