Get clearsky.reno tests passing again #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kandersolar
added
bug
kandersolar
commented
Jan 27, 2022
|
|
||
| @pytest.mark.skip(reason="GH #105") | ||
|
|
||
| @pytest.mark.skipif(is_old_pvlib, reason="GH #105") |
There was a problem hiding this comment.
Is this sufficient for #105? It's not clear to me what the outcome of that issue was.
There was a problem hiding this comment.
There was a problem hiding this comment.
What test values are there to update? These tests don't seem to use particularly precise hardcoded values anywhere, unless I'm missing something.
An aside: the commit message on 09e93a0 will automatically close #105, and I'm not sure how to prevent that now, so we'll have to manually reopen that issue if this is merged.
cwhanse
approved these changes
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The sphinx build in #127 is failing because of #126, and I figured might as well fix #105 while we're at it.
Checklist
[ ] Added new API functions todocs/api.rst[ ] Clearly documented all new API functions with PEP257 and numpydoc compliant docstringsin
docs/whatsnewfor all changes. Includes link to the GitHub Issue with
:issue:`num`or this Pull Request with
:pull:`num`. Includes contributor nameand/or GitHub username (link with
:ghuser:`user`).[ ] Non-API functions clearly documented with docstrings or comments as necessary[ ] Added tests to cover all new or modified code