Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ ] Closes #xxx[ ] Added tests to cover all new or modified code.[ ] Clearly documented all new API functions with PEP257 and numpydoc compliant docstrings.[ ] Added new API functions todocs/api.rst
.[ ] Non-API functions clearly documented with docstrings or comments as necessary.in
docs/whatsnew
for all changes. Includes link to the GitHub Issue with
:issue:`num`
or this Pull Request with
:pull:`num`
. Includes contributor nameand/or GitHub username (link with
:ghuser:`user`
).The tests are failing in #186 due to unrelated changes in scipy (see the 1.11.0 release notes):
In this line of code, the
.mode(...).mode
is now returning a scalar, so trying to index with[0]
fails:pvanalytics/pvanalytics/quality/time.py
Line 181 in 89d3c63
This PR switches away from
scipy.stats.mode
, which has too inconsistent an interface across all versions to be easily used here, and instead just usespd.Series.mode
.