Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port derivative-/quantile-based clipping detection from pvfleets QA #39
Port derivative-/quantile-based clipping detection from pvfleets QA #39
Changes from 35 commits
bd110b0
fc0e229
0c70f21
f224dc8
6a8e0b1
6fe29bc
14cf896
b12c9b2
fc164ea
92bfeea
bd94eaa
b985674
a6a9337
b3a6a1c
b95d130
296d8d6
51e838e
baacd50
dc31efa
d079493
c774652
0124fdb
edbe087
f81051e
b5a14d6
e4a0f05
13e49e7
956313d
c56caf8
232bb05
ba688a5
32355d6
a8b005c
15e3395
acc7e88
5594611
b4ceab2
e1e4f9e
1dfb7fc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the intent was to apply the median at each minute (of the day), is
powercurve.median()
is the median of thepowercurve
time series?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is the median for the whole power curve. The intent is to not mark periods of low power as clipping. This codifies the assumption that clipping will always be in periods of relatively high power.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm okay with this