Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add variables #102

Closed
dacoex opened this issue Nov 24, 2015 · 17 comments
Closed

doc: add variables #102

dacoex opened this issue Nov 24, 2015 · 17 comments
Milestone

Comments

@dacoex
Copy link
Contributor

dacoex commented Nov 24, 2015

Hello,

anything against adding
https://github.com/pvlib/pvlib-python/wiki/Variables-and-style-rules
to the sphinx docs?

this way, I have them with me also when offline.

@wholmgren
Copy link
Member

Sure, that makes sense now that the names have stabilized. Can you make a pr?

@dacoex
Copy link
Contributor Author

dacoex commented Nov 25, 2015

sure.

I suggest to use
http://docutils.sourceforge.net/docs/ref/rst/directives.html#csv-table

Do you agree?

dacoex pushed a commit to dacoex/pvlib-python that referenced this issue Nov 25, 2015
dacoex pushed a commit to dacoex/pvlib-python that referenced this issue Nov 26, 2015
inserted link to variables
@wholmgren wholmgren added this to the 0.3 milestone Nov 30, 2015
@wholmgren
Copy link
Member

Why do you prefer this to the standard sphinx table format? I think the sphinx format is easier to read in the doc source code.

@dacoex
Copy link
Contributor Author

dacoex commented Nov 30, 2015

Was fastest to implement.
Additionally, the csv values can be reused, e.g. to assign variables or translate variables into descriptions.

@wholmgren
Copy link
Member

Ok, well I am confused about the status since you closed your PR and deleted your branch. Please provide a link to rtd's rendering your branch when you (re)open your PR.

@dacoex
Copy link
Contributor Author

dacoex commented Dec 1, 2015

I am definitly not a git pro. But I tried to pack my 3 commits together. So maybe github closed it through the commands.
The link is here:
#103
Thanks.

@dacoex
Copy link
Contributor Author

dacoex commented Jan 15, 2016

Shall we also compare the parameter names with IEC 61724?

@wholmgren
Copy link
Member

You'll have to be more specific for me to understand what you're really proposing.

@dacoex
Copy link
Contributor Author

dacoex commented Jan 18, 2016

@wholmgren
Copy link
Member

I'm ok with adding a symbol column, but I don't think we should tie it to the IEC document. I would default to the PVPMC symbols.

@dacoex
Copy link
Contributor Author

dacoex commented Jan 18, 2016

I would default to the PVPMC symbols.

sure, the other one is just for reference.

But it's good in the case one performs performance evaluation with usually bases on the IEC or the contractual formulas.

an units are helpful, too.

@wholmgren
Copy link
Member

My preference is for a simple table that is focused on the pvlib-python standards. A handful of links to documents such as the IEC's and PVPMC website could be useful below the table.

@dacoex
Copy link
Contributor Author

dacoex commented Jan 18, 2016

mmh.

@wholmgren
Copy link
Member

I don't know what that means.

@dacoex
Copy link
Contributor Author

dacoex commented Jan 18, 2016

Let's start with your proposal.
Ideally, I'd love to have variables, units and refernce to standard side-by-side.

@dacoex
Copy link
Contributor Author

dacoex commented Jan 19, 2016

Comment #102 (comment) implemented in
#103

2 items I find strange:

  • RTD stylesheet / template does not support bulleted lists, see the test list below.
  • RTD stylesheet / template does not support line wrapping in CSV table directive.

I tested these 2 1 items with a fresh sphinx project and there it worked:
https://github.com/dacoex/pvlib_doc_testing/tree/master/build/html
https://raw.githubusercontent.com/dacoex/pvlib_doc_testing/master/build/html/variables_style_rules.html

Looking forward to your feedback to be able to close this issue ;-)

dacoex pushed a commit to dacoex/pvlib_doc_testing that referenced this issue Jan 19, 2016
wholmgren added a commit that referenced this issue Jan 20, 2016
@dacoex
Copy link
Contributor Author

dacoex commented Jan 25, 2016

Clsong since the PR #103 was merged.

@dacoex dacoex closed this as completed Jan 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants