-
Notifications
You must be signed in to change notification settings - Fork 987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ModelChain: unexpected errors when building with module from CECMod #621
Comments
Reproduced the behavior after fixing #620. You are correct, without module-specific parameters for one of the spectral modifier models, the only choice is
gets passed the model chain definition, if that advances your work. We haven't specified a default AOI model nor a default spectral model. The 'default' AOI model parameters are considered representative for untreated flat-glass modules. We could discuss making There are no default parameters for the spectral models, and the CEC database does not include values. The FirstSolar model requires precipitable water as input, which can be calculated from RH and air temperature using |
I think ModelChain is behaving as expected. Perhaps it can be documented better or the error messages can be more helpful (like suggesting users specify 'no_loss'). I deliberately chose to make this fail rather than default to 'no_loss'. As they say in |
The behavior of the |
Who is still having the CEC issue with the precipitable_water issue, this works for me:
|
Not sure this issue is a bug or a misuse from my side, but here is my problem.
When trying to build a
ModelChain
with module parameters found in the CEC database, several errors arise:ValueError: could not infer AOI model from system.module_parameters
physical
AOI model (chosen because I found in the code that this model has default parameters), when trying to run, I getKeyError: 'precipitable_water'
. It appears that the default spectral model expects'precipitable_water'
in weather data, and I could not find information on such a parameter in the documentation.no_loss
.To Reproduce
then
Expected behavior
Or a running ModelChain or clear errors indicating the bad parametrization, and potentially where to find information.
Versions:
pvlib.__version__
: 0.6.0pandas.__version__
: 0.23.4The text was updated successfully, but these errors were encountered: