Add optional return_components parameter to irradiance.haydavies
#1568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the Hay Davies sky transposition model to return individual components by user request.
|
Thanks @spaneja this looks like a great start. In addition to fixing the stickler/pep8 stuff, can you make a note of the new functionality and add your name to the contributors list in the 0.9.4 what's new file ( I'll take a closer look once the stickler issues are resolved, but one thing I notice now is that the (always zero) horizon component as mentioned in #1553 (comment) is missing. Thanks! |
Added in horizon component, which defaults to 0 or NaN. Also updating some stickler issues.
Updating formatting in file to be in line with stickler. Updating contributors list and corresponding information.
adding in test for when pandas is not being used.
updated tests for various data types.
kandersolar
approved these changes
Oct 13, 2022
There was a problem hiding this comment.
LGTM. Thanks @spaneja! I'll leave this open for now to allow any other interested parties to take a look.
kandersolar
changed the title
return_components parameter to irradiance.haydavies
|
Hearing no objections, I'll go ahead and merge this. Thanks again @spaneja |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the Hay Davies sky transposition model to return individual components by user request.
docs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.