Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to mamba-org/setup-micromamba #1758

Merged
merged 7 commits into from Jun 1, 2023
Merged

Conversation

d-watt
Copy link
Contributor

@d-watt d-watt commented Jun 1, 2023

Migrating to mamba-org/setup-micromamba, as outlined in #1746

d-watt and others added 4 commits May 23, 2023 22:53
Committer: Devon Watt <devon.watt@mail.mcgill.ca>

 On branch micromamba
 Changes to be committed:
	modified:   .github/workflows/pytest.yml
@d-watt
Copy link
Contributor Author

d-watt commented Jun 1, 2023

@wholmgren since it's my first pvlib pr, looks like some workflows require approval to trigger? I've taken a shot at addressing #1758, ready to review!

@kandersolar kandersolar added testing build tools Pipelines, CI, GH actions labels Jun 1, 2023
@kandersolar kandersolar added this to the 0.10.0 milestone Jun 1, 2023
@kandersolar kandersolar mentioned this pull request Jun 1, 2023
@kandersolar
Copy link
Member

Looks good to me, thanks @d-watt! Can you also make a brief note under Testing and add yourself to the contributors list in https://github.com/pvlib/pvlib-python/blob/main/docs/sphinx/source/whatsnew/v0.9.6.rst?

@d-watt
Copy link
Contributor Author

d-watt commented Jun 1, 2023

Thanks @kandersolar! Missed that in the contributing guidelines. Ready to re-review.
*er, hold on, will re-mention. I see the docs build failing.

Looks good to me, thanks @d-watt! Can you also make a brief note under Testing and add yourself to the contributors list in https://github.com/pvlib/pvlib-python/blob/main/docs/sphinx/source/whatsnew/v0.9.6.rst?

@d-watt d-watt closed this Jun 1, 2023
@d-watt d-watt reopened this Jun 1, 2023
@d-watt
Copy link
Contributor Author

d-watt commented Jun 1, 2023

Alright @kandersolar, ready for another look!

Copy link
Member

@kandersolar kandersolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @d-watt!

docs/sphinx/source/whatsnew/v0.9.6.rst Outdated Show resolved Hide resolved
@kandersolar kandersolar merged commit ef4e31b into pvlib:main Jun 1, 2023
24 of 25 checks passed
@wholmgren
Copy link
Member

Thanks @d-watt and @kandersolar!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build tools Pipelines, CI, GH actions testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replace provision-with-micromamba
3 participants