Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change read_tmy3 parameter input order #1791

Closed

Conversation

AdamRJensen
Copy link
Member

  • I am familiar with the contributing guidelines
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

Based on this #1779 (comment), it seems there is consensus that the map_variable parameter should be the last or second to last input parameters. This PR updates this for the read_tmy3 function (variable mapping of read_tmy3 has yet to be officially released, hence this PR is not a breaking change).

@kandersolar
Copy link
Member

I think it might make sense for technical mumbo-jumbo parameters like url and encoding to always be at the end of the parameter list. They aren't really "features" per se, they're just annoying "make it work" buttons that one resorts to using when something external to pvlib forces your hand.

@AdamRJensen AdamRJensen deleted the change_parameter_order_read_tmy3 branch June 28, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants