Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update get_ground_diffuse description #1883

Merged
merged 6 commits into from Feb 1, 2024
Merged

Update get_ground_diffuse description #1883

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
12bd36b
Update documentation
AdamRJensen Oct 5, 2023
52c5580
Add Cliff's statement
AdamRJensen Oct 5, 2023
9e397f7
Merge branch 'main' of https://github.com/pvlib/pvlib-python into gro…
cwhanse Feb 1, 2024
ea7cdd6
undo edits to v0.10.3 whatsnew
cwhanse Feb 1, 2024
5a11ef1
whatsnew
cwhanse Feb 1, 2024
6e44640
Update pvlib/irradiance.py
cwhanse Feb 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/sphinx/source/whatsnew/v0.10.3.rst
View file
Open in desktop
Expand Up @@ -28,4 +28,5 @@ Contributors
~~~~~~~~~~~~
* Arjan Keeman (:ghuser:`akeeman`)
* Miguel Sánchez de León Peque (:ghuser:`Peque`)
* Will Hobbs (:ghuser:`williamhobbs`)
* Will Hobbs (:ghuser:`williamhobbs`)
* Adam R. Jensen (:ghuser:`AdamRJensen`)
3 changes: 2 additions & 1 deletion pvlib/irradiance.py
View file
Open in desktop
Expand Up @@ -542,7 +542,8 @@ def poa_components(aoi, dni, poa_sky_diffuse, poa_ground_diffuse):
def get_ground_diffuse(surface_tilt, ghi, albedo=.25, surface_type=None):
'''
Estimate diffuse irradiance from ground reflections given
irradiance, albedo, and surface tilt.
irradiance, albedo, and surface tilt. The ground is assumed to
be isotropic and reflections are Lambertian.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
be isotropic and reflections are Lambertian.
be horizontal and flat, and reflections are Lambertian.

I don't think the word isotropic is appropriate here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding "horizontal and flat" is a good idea. isotropic refers to properties such as albedo

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to use the word isotropic I would suggest something more like: the surface is Lambertian and the reflected radiance is isotropic.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can live with that.

cwhanse marked this conversation as resolved.
Show resolved Hide resolved

Function to determine the portion of irradiance on a tilted surface
due to ground reflections. Any of the inputs may be DataFrames or
Expand Down