Improve docstring for get_ground_diffuse #1953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echedey-ls
reviewed
Jan 26, 2024
adriesse
reviewed
Jan 28, 2024
pvlib/irradiance.py
Outdated
| Notes | ||
| ----- | ||
| Ground diffuse irradiance is the the last term of equations 3, 4, 7, 8, | ||
| 10, 11, and 12 in [1]_. Table of albedo values by ``surface_type`` |
There was a problem hiding this comment.
Could you describe what that last term is, rather than refer to a paper that's not openly accessible?
There was a problem hiding this comment.
There's a preprint here but one has to find it by searching the title.
kandersolar
approved these changes
Jan 29, 2024
Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ ] Closes #xxxx[ ] Tests added[ ] Updates entries indocs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.Reformat reference section and update links in
get_ground_diffuse.Fresh snow albedo value in
irradiance.SURFACE_ALBEDOSconflicts with sources. Perhaps we change to 0.80 (wikipedia value); PVsyst uses 0.82.