Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix more broken links #1960

Merged
merged 12 commits into from Feb 8, 2024
Merged

Fix more broken links #1960

merged 12 commits into from Feb 8, 2024

Conversation

cwhanse
Copy link
Member

@cwhanse cwhanse commented Feb 1, 2024

  • [ ] Closes #xxxx
  • I am familiar with the contributing guidelines
  • [ ] Tests added
  • [ ] Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • [ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

Yet more link repairs in response to #1794

@cwhanse cwhanse added this to the v0.10.4 milestone Feb 1, 2024
@cwhanse cwhanse mentioned this pull request Feb 1, 2024
5 tasks
@echedey-ls
Copy link
Contributor

echedey-ls commented Feb 2, 2024

Solve run linkchecker locally

Ah, I see the problem you reported on #1794 - your repo doesn't have the tags fetched from the main branch, so when you try to install the requirements, there's an issue regarding the pvfactors/solarfactors switch. (EDIT: I mean, due to the versions, since the current PVLIB version in any install is a mangled string from the last known tag)

You may need to resync tags to run the commands accordingly:

git fetch -p -P https://github.com/pvlib/pvlib-python/

or this one that sets config values so you don't miss that again

git config fetch.prune true
git config fetch.pruneTags true
git fetch https://github.com/pvlib/pvlib-python/

Reports

Anyways, here is the report on this branch WITH dx.doi.org broken link warnings:

Details

(venv) (base) upm@upm00477:~/pvlib-python/docs/sphinx$ python -m sphinx -b linkcheck -T -W --keep-going source build/linkcheck | awk '/broken/ && !(/github/)'source/whatsnew/v0.9.1.rst:16: WARNING: undefined label: forecasts
(reference/generated/pvlib.irradiance.boland: line   46) broken    http://dx.doi.org/10.1002/1099-095X(200103)12:2%3C103::AID-ENV447%3E3.0.CO;2-2 - 403 Client Error: Forbidden for url: https://onlinelibrary.wiley.com/doi/10.1002/1099-095X(200103)12:2%3C103::AID-ENV447%3E3.0.CO;2-2
(reference/generated/pvlib.atmosphere.gueymard94_pw: line   46) broken    http://dx.doi.org/10.1002/pip.517 - 403 Client Error: Forbidden for url: https://onlinelibrary.wiley.com/doi/10.1002/pip.517
(reference/generated/pvlib.temperature.faiman: line   37) broken    http://dx.doi.org/10.1002/pip.813 - 403 Client Error: Forbidden for url: https://onlinelibrary.wiley.com/doi/10.1002/pip.813
(reference/generated/pvlib.singlediode.bishop88: line   80) broken    http://dx.doi.org/10.1109/16.658676 - 418 Client Error: Unknown Code for url: https://ieeexplore.ieee.org/document/658676/
(reference/generated/pvlib.temperature.prilliman: line   42) broken    http://dx.doi.org/10.1109/JPHOTOV.2020.2992351 - 418 Client Error: Unknown Code for url: https://ieeexplore.ieee.org/document/9095219/
(reference/generated/pvlib.ivtools.sdm.fit_pvsyst_sandia: line   92) broken    http://dx.doi.org/10.1109/JPHOTOV.2014.2364133 - 418 Client Error: Unknown Code for url: https://ieeexplore.ieee.org/document/6951401
(reference/generated/pvlib.soiling.hsu: line   32) broken    http://dx.doi.org/10.1109/JPHOTOV.2019.2919628 - 418 Client Error: Unknown Code for url: https://ieeexplore.ieee.org/document/8735892/
(gallery/adr-pvarray/plot_fit_to_matrix: line  185) broken    http://dx.doi.org/10.1109/JPHOTOV.2020.3045677 - 418 Client Error: Unknown Code for url: https://ieeexplore.ieee.org/document/9323039/
(reference/generated/pvlib.snow.loss_townsend: line   48) broken    http://dx.doi.org/10.1109/PVSC.2011.6186627 - 418 Client Error: Unknown Code for url: https://ieeexplore.ieee.org/document/6186627/
(reference/generated/pvlib.iam.sapm: line   31) broken    http://dx.doi.org/10.1109/PVSC.2015.7355849 - 418 Client Error: Unknown Code for url: https://ieeexplore.ieee.org/document/7355849/
(reference/generated/pvlib.ivtools.sde.fit_sandia_simple: line  107) broken    http://dx.doi.org/10.1109/PVSC40753.2019.8981330 - 418 Client Error: Unknown Code for url: https://ieeexplore.ieee.org/document/8981330/
(reference/generated/pvlib.ivtools.sdm.fit_desoto_sandia: line   90) broken    http://dx.doi.org/10.1109/PVSC.2013.6744135 - 418 Client Error: Unknown Code for url: https://ieeexplore.ieee.org/document/6744135/
(reference/generated/pvlib.bifacial.infinite_sheds.get_irradiance: line  114) broken    http://dx.doi.org/10.1109/PVSC40753.2019.8980572 - 418 Client Error: Unknown Code for url: https://ieeexplore.ieee.org/document/8980572/
(gallery/soiling/plot_greensboro_kimber_soiling: line   33) broken    http://dx.doi.org/10.1109/WCPEC.2006.279690 - 418 Client Error: Unknown Code for url: https://ieeexplore.ieee.org/document/4060159/
(reference/generated/pvlib.spectrum.spectral_factor_caballero: line   39) broken    http://dx.doi.org/10.1109/jphotov.2017.2787019 - 418 Client Error: Unknown Code for url: https://ieeexplore.ieee.org/document/8254355/
(reference/generated/pvlib.atmosphere.angstrom_aod_at_lambda: line   24) broken    http://dx.doi.org/10.1111/j.2153-3490.1961.tb00078.x - 403 Client Error: Forbidden for url: https://www.tandfonline.com/zela
(reference/generated/pvlib.atmosphere.bird_hulstrom80_aod_bb: line   20) broken    http://dx.doi.org/10.1115/1.3266239 - 403 Client Error: Forbidden for url: https://asmedigitalcollection.asme.org/solarenergyengineering/article/103/3/182/418320/Review-Evaluation-and-Improvement-of-Direct
(reference/generated/pvlib.ivtools.sdm.fit_cec_sam: line   53) broken    http://dx.doi.org/10.1115/1.4005759 - 403 Client Error: Forbidden for url: https://asmedigitalcollection.asme.org/solarenergyengineering/article/doi/10.1115/1.4005759/455696/An-Improved-Coefficient-Calculator-for-the
(reference/generated/pvlib.atmosphere.angstrom_aod_at_lambda: line   19) broken    http://dx.doi.org/10.2307/519399 - 403 Client Error: Forbidden for url: https://www.jstor.org/stable/519399?origin=crossref
(reference/generated/pvlib.irradiance.get_ground_diffuse: line   35) broken    http://files.pvsyst.com/help/albedo.htm - HTTPConnectionPool(host='files.pvsyst.com', port=80): Max retries exceeded with url: /help/albedo.htm (Caused by NameResolutionError("<urllib3.connection.HTTPConnection object at 0x7f24bae59cd0>: Failed to resolve 'files.pvsyst.com' ([Errno -2] Nombre o servicio desconocido)"))
(reference/generated/pvlib.solarposition.spa_c: line   40) broken    http://rredc.nrel.gov/solar/codesandalgorithms/spa/ - 404 Client Error: Not Found for url: https://www.nrel.gov/wind/solar/codesandalgorithms/spa/
(reference/generated/pvlib.clearsky.ineichen: line   48) broken    http://www.soda-is.com/eng/services/climat_free_eng.php#c5 - 404 Client Error: Not Found for url: http://www.soda-is.com/eng/services/climat_free_eng.php
(reference/generated/pvlib.iotools.get_acis_mpe: line    2) broken    https://data.rcc-acis.org/GridData - 400 Client Error: Bad Request for url: https://data.rcc-acis.org/GridData
(reference/generated/pvlib.irradiance.get_ground_diffuse: line   35) broken    https://doi.org/10.1175/1520-0469(1972 - 404 Client Error: Not Found for url: https://doi.org/10.1175/1520-0469(1972
(           index: line   87) broken    https://doi.org/10.1109/PVSC.2014.6925501 - 418 Client Error: Unknown Code for url: https://ieeexplore.ieee.org/document/6925501/
(reference/generated/pvlib.iotools.get_pvgis_hourly: line  131) broken    https://ec.europa.eu/jrc/en/PVGIS/docs/noninteractive - 404 Client Error: Not Found for url: https://joint-research-centre.ec.europa.eu/PVGIS/docs/noninteractive_en
(reference/generated/pvlib.solarposition.spa_c: line   49) broken    https://en.wikipedia.org/wiki/%CE%94T_(timekeeping - 404 Client Error: Not Found for url: https://en.wikipedia.org/wiki/%CE%94T_(timekeeping
(reference/generated/pvlib.iotools.read_epw: line    6) broken    https://energyplus.net/weather - 404 Client Error: Not Found for url: https://energyplus.net/weather
(reference/generated/pvlib.iotools.parse_epw: line   13) broken    https://energyplus.net/documentation - 404 Client Error: Not Found for url: https://energyplus.net/documentation
(reference/generated/pvlib.solarposition.spa_python: line   60) broken    http://www.usno.navy.mil/USNO/earth-orientation/eo-products/long-term - ('Connection aborted.', ConnectionResetError(104, 'Conexión reinicializada por la máquina remota'))
(reference/generated/pvlib.iotools.get_pvgis_hourly: line    2) broken    https://re.jrc.ec.europa.eu/api/v5_2/ - 404 Client Error: NOT FOUND for url: https://re.jrc.ec.europa.eu/api/v5_2/
(user_guide/installation: line   51) broken    https://www.anaconda.com/what-is-anaconda/ - 404 Client Error: Not Found for url: https://www.anaconda.com/what-is-anaconda/
(reference/generated/pvlib.temperature.pvsyst_cell: line   60) broken    https://www.pvsyst.com/help/index.html?thermal_loss.htm - HTTPSConnectionPool(host='www.pvsyst.com', port=443): Max retries exceeded with url: /help/index.html?thermal_loss.htm (Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1091)')))
(reference/generated/pvlib.pvsystem.dc_ohmic_losses: line   15) broken    https://www.pvsyst.com/help/ohmic_loss.htm - HTTPSConnectionPool(host='www.pvsyst.com', port=443): Max retries exceeded with url: /help/ohmic_loss.htm (Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1091)')))
(reference/generated/pvlib.iam.ashrae: line   37) broken    https://www.pvsyst.com/help/index.html?iam_loss.htm - HTTPSConnectionPool(host='www.pvsyst.com', port=443): Max retries exceeded with url: /help/index.html?iam_loss.htm (Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1091)')))

And WITHOUT those dx.doi.org warnings:

Details

undefined label: forecasts
(reference/generated/pvlib.irradiance.get_ground_diffuse: line   35) broken    http://files.pvsyst.com/help/albedo.htm - HTTPConnectionPool(host='files.pvsyst.com', port=80): Max retries exceeded with url: /help/albedo.htm (Caused by NameResolutionError("<urllib3.connection.HTTPConnection object at 0x7f24bae59cd0>: Failed to resolve 'files.pvsyst.com' ([Errno -2] Nombre o servicio desconocido)"))
(reference/generated/pvlib.solarposition.spa_c: line   40) broken    http://rredc.nrel.gov/solar/codesandalgorithms/spa/ - 404 Client Error: Not Found for url: https://www.nrel.gov/wind/solar/codesandalgorithms/spa/
(reference/generated/pvlib.clearsky.ineichen: line   48) broken    http://www.soda-is.com/eng/services/climat_free_eng.php#c5 - 404 Client Error: Not Found for url: http://www.soda-is.com/eng/services/climat_free_eng.php
(reference/generated/pvlib.iotools.get_acis_mpe: line    2) broken    https://data.rcc-acis.org/GridData - 400 Client Error: Bad Request for url: https://data.rcc-acis.org/GridData
(reference/generated/pvlib.irradiance.get_ground_diffuse: line   35) broken    https://doi.org/10.1175/1520-0469(1972 - 404 Client Error: Not Found for url: https://doi.org/10.1175/1520-0469(1972
(           index: line   87) broken    https://doi.org/10.1109/PVSC.2014.6925501 - 418 Client Error: Unknown Code for url: https://ieeexplore.ieee.org/document/6925501/
(reference/generated/pvlib.iotools.get_pvgis_hourly: line  131) broken    https://ec.europa.eu/jrc/en/PVGIS/docs/noninteractive - 404 Client Error: Not Found for url: https://joint-research-centre.ec.europa.eu/PVGIS/docs/noninteractive_en
(reference/generated/pvlib.solarposition.spa_c: line   49) broken    https://en.wikipedia.org/wiki/%CE%94T_(timekeeping - 404 Client Error: Not Found for url: https://en.wikipedia.org/wiki/%CE%94T_(timekeeping
(reference/generated/pvlib.iotools.read_epw: line    6) broken    https://energyplus.net/weather - 404 Client Error: Not Found for url: https://energyplus.net/weather
(reference/generated/pvlib.iotools.parse_epw: line   13) broken    https://energyplus.net/documentation - 404 Client Error: Not Found for url: https://energyplus.net/documentation
(reference/generated/pvlib.solarposition.spa_python: line   60) broken    http://www.usno.navy.mil/USNO/earth-orientation/eo-products/long-term - ('Connection aborted.', ConnectionResetError(104, 'Conexión reinicializada por la máquina remota'))
(reference/generated/pvlib.iotools.get_pvgis_hourly: line    2) broken    https://re.jrc.ec.europa.eu/api/v5_2/ - 404 Client Error: NOT FOUND for url: https://re.jrc.ec.europa.eu/api/v5_2/
(user_guide/installation: line   51) broken    https://www.anaconda.com/what-is-anaconda/ - 404 Client Error: Not Found for url: https://www.anaconda.com/what-is-anaconda/
(reference/generated/pvlib.temperature.pvsyst_cell: line   60) broken    https://www.pvsyst.com/help/index.html?thermal_loss.htm - HTTPSConnectionPool(host='www.pvsyst.com', port=443): Max retries exceeded with url: /help/index.html?thermal_loss.htm (Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1091)')))
(reference/generated/pvlib.pvsystem.dc_ohmic_losses: line   15) broken    https://www.pvsyst.com/help/ohmic_loss.htm - HTTPSConnectionPool(host='www.pvsyst.com', port=443): Max retries exceeded with url: /help/ohmic_loss.htm (Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1091)')))
(reference/generated/pvlib.iam.ashrae: line   37) broken    https://www.pvsyst.com/help/index.html?iam_loss.htm - HTTPSConnectionPool(host='www.pvsyst.com', port=443): Max retries exceeded with url: /help/index.html?iam_loss.htm (Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1091)')))

Suggestions

dx.doi.org warnings make 19/36 of the reported broken links. I'm not sure, but the problem may be fixed by changing them to doi.org, since the latter form is preferred by the documentation (wikipedia link)

I'd remove the forecasts reference and just type it as inline code. It broke the moment the module was deleted from the repo.

This is kinda the moment I wish we had merged some GH workflow hehe.

@cwhanse
Copy link
Member Author

cwhanse commented Feb 2, 2024

This is kinda the moment I wish we had merged some GH workflow hehe.

+1

@kandersolar
Copy link
Member

Thanks @cwhanse and @echedey-ls! I already used some of them myself, so there's already one person happy for these fixes :P

@kandersolar kandersolar merged commit 26acf8a into pvlib:main Feb 8, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants