Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ ] Updates entries indocs/sphinx/source/reference
for API changes.docs/sphinx/source/whatsnew
for all changes. Includes link to the GitHub Issue with:issue:`num`
or this Pull Request with:pull:`num`
. Includes contributor name and/or GitHub username (link with:ghuser:`user`
).[ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.remote-data
) and Milestone are assigned to the Pull Request and linked Issue.The necessary changes are all minor:
np.NaN
tonp.nan
np.Inf
tonp.inf
np.uint8
casting issuescipy.integrate.trapezoid
instead ofnp.trapz
The last item is only to address a deprecation warning: numpy 2.0 deprecated
np.trapz
in favor of eithernp.trapezoid
orscipy.integrate.trapezoid
. To avoid the small code cruft of usingtry/except
for importing from numpy (to support bothtrapz
for numpy < 2 andtrapezoid
for numpy >= 2), I opted to use the scipy function. That required increasing our minimum version from 1.5 to 1.6.