Modify initial Voc for bishop88 functions #2032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kandersolar
reviewed
May 2, 2024
Closed
echedey-ls
pushed a commit
to echedey-ls/pvlib-python
that referenced
this pull request
May 22, 2024
* modify bishop88_mpp * lint * extend coverage to v_from_i, i_from_v * lint * whatsnew --------- Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
d2mutauandNsVbiparameters #2013docs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.Restrict the starting Voc to be less than
NsVbiforbishop88functions for eithermethod='newton'ormethod='brentq'. Doing so increases likelihood of convergence when the estimated Voc is greater thanNsVbi, and also addresses a number of warnings. This change only affects single diode modeling when parametersNsVbiandd2mutauare changed from defaults ofnp.infand 0, respectively. These parameters are relevant for PVsyst models of amorphous Si and CdTe cells.gist comparing function failures before and after this change.