Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove read_srml_month_from_solardat #2061

Closed
wants to merge 1 commit into from

Conversation

echedey-ls
Copy link
Contributor

@echedey-ls echedey-ls commented May 23, 2024

  • [ ] Closes #xxxx
  • I am familiar with the contributing guidelines
  • [ ] Tests added
  • Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • [ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

It was marked to be removed, no PR or issue found.

@echedey-ls
Copy link
Contributor Author

echedey-ls commented May 23, 2024

Does the removal of deprecated features require a whatsnew entry?

@echedey-ls echedey-ls marked this pull request as ready for review May 23, 2024 12:17
@AdamRJensen AdamRJensen added io remote-data triggers --remote-data pytests labels May 24, 2024
@AdamRJensen
Copy link
Member

Closing this as it is a duplicate of #1989.

@echedey-ls echedey-ls deleted the smrl-deprecation-removal branch May 24, 2024 09:32
@echedey-ls
Copy link
Contributor Author

Damn, I may have missed it from the milestone page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
io remote-data triggers --remote-data pytests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants