Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set map_variables=True by default in PSM3 iotools functions #2094

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

kandersolar
Copy link
Member

@kandersolar kandersolar commented Jun 17, 2024

  • Closes Change PSM3 map_variables default value #1425
  • I am familiar with the contributing guidelines
  • Tests added
  • [ ] Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

This PR changes map_variables to default to True in the PSM3 iotools functions. It has defaulted to False (with a deprecation warning) since v0.9.1 when the option was originally introduced.

@kandersolar kandersolar added this to the 0.11.0 milestone Jun 17, 2024
@kandersolar kandersolar added the remote-data triggers --remote-data pytests label Jun 17, 2024
@kandersolar kandersolar marked this pull request as ready for review June 17, 2024 13:46
@kandersolar kandersolar merged commit cc027e4 into pvlib:main Jun 19, 2024
36 checks passed
@kandersolar kandersolar deleted the psm3-map_variables branch June 19, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api io remote-data triggers --remote-data pytests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change PSM3 map_variables default value
2 participants