Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ModelChain.prepare_inputs fails to pass solar_position and airmass to Location.get_clearsky #482

Merged
merged 2 commits into from Jun 20, 2018

Conversation

wholmgren
Copy link
Member

@wholmgren wholmgren commented Jun 16, 2018

  • Closes ModelChain.prepare_inputs fails to pass solar_position and airmass to Location.get_clearsky #481
  • Fully tested. Added and/or modified tests to ensure correct behavior for all reasonable inputs. Tests must pass on the TravisCI and Appveyor testing services.
  • Code quality and style is sufficient. Passes git diff upstream/master -u -- "*.py" | flake8 --diff and/or landscape.io linting service.
  • New code is fully documented. Includes sphinx/numpydoc compliant docstrings and comments in the code where necessary.
  • Updates entries to docs/sphinx/source/api.rst for API changes.
  • Adds description and name entries in the appropriate docs/sphinx/source/whatsnew file for all changes.

Not sure how to test this or if it's worth the time investment. I recommend double checking the code is right and merging.

@wholmgren wholmgren added the bug label Jun 16, 2018
@wholmgren wholmgren added this to the 0.6.0 milestone Jun 16, 2018
@cwhanse cwhanse merged commit ec99661 into pvlib:master Jun 20, 2018
@wholmgren wholmgren deleted the mc_zenith_data branch June 26, 2018 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants