-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New player and theming #54
Conversation
Yeesh that took a long time. New player includes: + New icons (need to change one) + Snazzy login screen + Begone, LISTS. We have _grids_ here, which means that the station list & history list are now grids + just general tomfoolery + settings screen now shows a full* preview, not just a placeholder square *ok full admission you can't interact with it and it doesn't show the other panels, but it's still PRETTY GOOD
Awesome to see this in a PR. I'll probably move the conversation here since it should be easier to reference code directly.
I think that covers everything for now. I'm happy to pick some of these up, but I don't have any familiarity with the CSS stuff (yet), so you're probably better suited to tackle them. Once again, fantastic work! |
Oh, and IDK if you were affected by this, but something to note: https://haveibeenpwned.com/PwnedWebsites#000webhost |
Well... yes... but it makes the code a lot less clean.
Resolved (I think) 👍
👍, I would do the same. Not that I'm untrusting, but letting a random stranger on the internet put unreviewed code into my extension seems like a bad idea.
Sure, I'll do a global search+replace for tabs -> four spaces
I think I know what's causing that?? I'll try to figure it out
Ah, good idea. I'll get to working on that.
Thanks :) |
So the original solution I did for the hover colors on the buttons (which were PNGs) was to CSS Does that sound sane to you? I don't really know CSS too well |
That's actually... a very, very good idea, or at least the start of one. |
Alright, now everything is fixed except for recoloring the buttons. |
it's a foreground bit, you could just make it the same as I'll poke around with the RGB to HSV math a bit, see if I can't make something goofy work |
Yeah, after about 2 hours of trying, I'm giving up and making the HTML messy. rip function fillSvgs() {
let x = document.querySelectorAll('svg');
for (let i = 0; i < x.length; i++) {
fetch(x[i].getAttribute('data-src')).then((d) => {
d.text().then((e) => {
x.setAttribute('xmlns', 'http://www.w3.org/2000/svg');
x.setAttribute('viewBox', x.match(/viewBox="[0-9 ]*"/g)[0].match(/"[0-9 ]*/g)[0].substring(1));
x[i].innerHTML = e.replace(/<svg[A-Za-z 0-9"=\n:/.\-]*>/g,'').replace(/<\/svg>/g, '');
});
});
}
} |
I've gotta get some food, this is giving me a headache. |
Oh no... I hope this doesn't ruin everything, but using https://developer.chrome.com/extensions/security#avoid https://developer.mozilla.org/en-US/docs/Web/API/Element/innerHTML#Security_considerations |
https://codepen.io/sosuke/pen/Pjoqqp This is an option |
Ooo, that looks good. I'll see what I can do with it, as what I've been doing before has been... unfruitful. |
Found this very clever solution: |
That looks absolutely perfect! |
Hell yeah! Appropriate song title too
…On Sun, May 17, 2020, 1:28 AM hucario ***@***.***> wrote:
Alright, I'm getting off for the night, but before I go, here's a smidgen
of hope:
[image: image]
<https://user-images.githubusercontent.com/50851047/82136627-935dbe80-97c4-11ea-825b-73d7140cfe83.png>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#54 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABVCK4P2VDRFUB6NGTE757TRR5YZFANCNFSM4NDBJKFQ>
.
|
@pvrs12 |
that took _way_ too long, but at least it's done now ¯\_(ツ)_/¯
yeah, I'm about done. you can do your code-checking now. |
sorry - NOW I'm done. don't check the code that was there before the latest commit, it was trash anyways |
Awesome, giving it an eye-ball now |
Moving to new branch to merge prior to some code changes I'm going to make |
wow, that title sounds underwhelming.
This has been an ongoing discussion over in #53, so none of this is news, but...
Wow! A new player, with
and that's not all!
You also get:
A theming page with
12810 theming optionsPlus, if you don't like it, the old player is still there! No changes to it
that you can see! Nada! If you don't like it, take it back to the store for a refund!"but hucario, " - I hear you ask - "we still have no screenshots! How are we supposed to judge whether this is actually quality?"
![image](https://user-images.githubusercontent.com/50851047/82128319-15bb9380-976f-11ea-8786-735a8e60459a.png)
![image](https://user-images.githubusercontent.com/50851047/82128322-1a804780-976f-11ea-970b-8354c0742b2f.png)
![image](https://user-images.githubusercontent.com/50851047/82128342-47345f00-976f-11ea-8287-a0ef6332f8e8.png)
Say no more!
(don't mind my terrible taste in music)
(why was They Might Be Giants playing on "chillstep radio"??)