Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do you plan to make it works with awesome 4.0 #8

Closed
jorgemota opened this issue Jan 20, 2017 · 21 comments
Closed

Do you plan to make it works with awesome 4.0 #8

jorgemota opened this issue Jan 20, 2017 · 21 comments

Comments

@jorgemota
Copy link

I am trying to fix your rc.lua with awesome 4.0 (Released today on arch) but give random errors every time I fixed something >.< and I am wondering if you are going to upgrade :D

@pw4ever
Copy link
Owner

pw4ever commented Jan 20, 2017

@jorgemota Thanks for the heads up. I think I got work to do after my next "pacman -Syu".

@jorgemota
Copy link
Author

thanks man! I am using your configuraton, and I liked it :D 💃

@pw4ever
Copy link
Owner

pw4ever commented Jan 20, 2017

Thanks for letting me know. Glad you find it useful :)

Will close this issue after making it compatible with Awesome 4.0.

@jorgemota
Copy link
Author

Ok, by the way, my first problem was referenced to awesomeWM/awesome#244

after pacman -Syyuu, in /usr/share/awesome/lib exists folder beautify and beautiful.lua and awesome got crazy and throws a lot of errors about textbox, widget, etc, removing beautiful.lua let me work with your configuration up 40% (before was at 5% >.<)

@pw4ever
Copy link
Owner

pw4ever commented Jan 21, 2017

@jorgemota I don't think Awesome 4.0 is stable enough to be moved to.

I have fixed errors due to non-backward-compatible API changes (e.g., with regard to mouse.screen => awful.screen.focused() etc.).

However, I run into the following internal errors with awful.prompt:

/usr/share/awesome/lib/awful/prompt.lua:408: attempt to call a nil value (method 'set_font')

This error is caused by textbox widget's "set_font" method being replaced by "font" property (perhaps in the "expose data not accessor" anti-unnecessary-encapsulation philosophy as in Clojure, which I agree with), without providing a shim for the older accessor. This is quite disrupting.

So it appears that the API change in Awesome 4.0 has caused issues even for its own inbox library.

For now, I am downgrading to the perfectly working v3.5.9, and have added "awesome" to my pacman.conf IgnorePkg list. I will consider moving to v4.x when 4.x is stable enough.

My work-in-progress changes is here: https://github.com/pw4ever/awesome-wm-config/tree/next-4.x

@jorgemota
Copy link
Author

OH.. I am going to downgrade too thanks for your works.

@jorgemota
Copy link
Author

I got working awesome again with your version, only commented all body function update_textbox on uniargs. and no more errors :)

@jorgemota
Copy link
Author

jorgemota commented Jan 22, 2017

Using awesome-git and the rc.lua from https://github.com/pw4ever/awesome-wm-config/tree/next-4.x

I needed to edit uniargs.lua and remove body method for update_texbox function.

Last thing I needed to change in rc.lua was this:

[[awful.key({modkey}, "r", function()
awful.prompt.run(
{prompt = "Run: "},
customization.widgets.promptbox[awful.screen.focused().index],
awful.util.spawn, awful.completion.shell,
awful.util.getdir("cache") .. "/history"
)
end),

Changed to: (same function used in Modkey + f2 )
awful.key({modkey}, "r", function()
awful.prompt.run(
{prompt = "Run: "},
customization.widgets.promptbox[awful.screen.focused().index].widget,
awful.util.spawn, awful.completion.shell,
awful.util.getdir("cache") .. "/history"
)
end),

And now I don't get any error anymore 🗡️

@pw4ever
Copy link
Owner

pw4ever commented Jan 23, 2017

@jorgemota
I have released an update that is compatible with Awesome 4.0 (at least in my local test).

Please give it a try and let me know if it also works for you.

@jorgemota
Copy link
Author

Nice work, , moved to branch I am going to test it tomorrow, thanks for the changes. first tests don't show any error.

@pw4ever
Copy link
Owner

pw4ever commented Jan 23, 2017

@jorgemota Had some new updates with regard to multi-screen support. Please git-pull and test the latest version (4.0.1). Thanks!

@pw4ever
Copy link
Owner

pw4ever commented Jan 23, 2017

@jorgemota Latest one is 4.0.2, with client rules update.

@jorgemota
Copy link
Author

Updated to 4.0.2 and I lost the systray for icons. Skype, pidgin, nm-applet is not showing icon in systray :(

@pw4ever
Copy link
Owner

pw4ever commented Jan 23, 2017

@jorgemota
Thanks for catching the bug. Should be fixed now in 4.0.3.

@jorgemota
Copy link
Author

Hi @pw4ever I don't see any commit or changes :)

@pw4ever
Copy link
Owner

pw4ever commented Jan 23, 2017

@jorgemota
My apologies. Messed up git-pushing. Now should fixed.
Thanks for the patience :)

@jorgemota
Copy link
Author

thanks to you! I got back my old systray with this commit !

@jorgemota
Copy link
Author

I am wondering, can you please add some file or properties file (External to avoid rewrite on update), to read if user want cpu, battery, and mdp? every time I update lost my customization on date format, removed cpu/memory and I dont use mdp :P thanks for all the work man.

@pw4ever
Copy link
Owner

pw4ever commented Jan 23, 2017

@jorgemota
For this specific use case, I would recommend you clone the repo and create a local-jorgemota-4.x branch (like my local-1pengw-4.x branch) that have your customization.

Then when you pull a new awesome-4.x branch, you can just:

git checkout local-jorgemota-4.x
git merge awesome-4.x

which will port your customization forward. This is what I have been doing so far.

@jorgemota
Copy link
Author

ohh, I will give this a try. Thanks man.

@pw4ever
Copy link
Owner

pw4ever commented Jan 23, 2017

@jorgemota I will close this issue for now. Thanks for testing this out!

@pw4ever pw4ever closed this as completed Jan 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants