Changed manifest transformations for Windows 10 Hosted Apps. By defau…

…lt, WindowsRuntimeAccess attribute of ACUR rules is set to 'all' if no access type is specified in mjs_api_access
pwa-builder · Nov 19, 2015 · 831e57d · 831e57d
1 parent 00abe4b
commit 831e57d
Show file tree

Hide file tree

Showing 2 changed files with 37 additions and 1 deletion.
diff --git a/lib/platformUtils/windows10Utils.js b/lib/platformUtils/windows10Utils.js
@@ -125,7 +125,7 @@ function replaceManifestValues(w3cManifestInfo, content) {
                 return false;
       }   
 
-      tryAddAcurToList(acurList, { match: apiRule.match, runtimeAccess: apiRule.access });
+      tryAddAcurToList(acurList, { match: apiRule.match, runtimeAccess: apiRule.access || 'all' });
     });
   } 
 

diff --git a/test/manifestTools/transformations/windows10.js b/test/manifestTools/transformations/windows10.js
@@ -640,6 +640,42 @@ describe('transformation: Windows 10 Manifest', function () {
       });
     });
 
+    it('Should add ACUR from mjs_api_access with default access type \'all\' if no access type is specified', function (done) {
+      var siteUrl = 'http://url.com/something?query';
+      var shortName = 'shortName';
+
+      var originalManifestInfo = {
+        content: {
+          'start_url': siteUrl,
+          'short_name': shortName,
+          'mjs_api_access': [
+            { 'match': 'http://url.com/somepath/', 'platform': 'windows10'}
+          ]
+        }
+      };
+
+      transformation.convertFromBase(originalManifestInfo, function (err, result) {
+        should.not.exist(err);
+        should.exist(result);
+        /*jshint -W030 */
+        result.should.have.property('content').which.is.an.Object;
+        result.should.have.property('format', 'windows10');
+
+        var manifest = result.content;
+
+        manifest.should.have.property('rawData');
+
+        var expectedContentUriRules = '<uap:ApplicationContentUriRules>' +
+                                        '<uap:Rule Type="include" WindowsRuntimeAccess="none" Match="http://url.com/" />' +
+                                        '<uap:Rule Type="include" WindowsRuntimeAccess="all" Match="http://url.com/somepath/" />' +
+                                      '</uap:ApplicationContentUriRules>';
+
+        manifest.rawData.replace(/[\t\r\n]/g, '').indexOf(expectedContentUriRules).should.be.above(-1);
+
+        done();
+      });
+    });
+
     it('Should not add ACUR from mjs_api_access if windows10 is not in platform', function (done) {
       var siteUrl = 'http://url.com/something?query';
       var shortName = 'shortName';