Skip to content
This repository has been archived by the owner on Jan 14, 2022. It is now read-only.

Accept-encoding: gzip for manifest.json #37

Merged
merged 3 commits into from
Nov 2, 2017

Conversation

staticshock
Copy link
Contributor

I've noticed an error loading the manifest on https://newsela.com due to the manifest always being gzipped. Any chance we could just add gzip support to the loader? I played around with it a bit, passing a gzip parameter to the request lib seems to be sufficient.

@pwa-builder pwa-builder deleted a comment from msftclas Sep 26, 2017
@boyofgreen boyofgreen changed the base branch from master to dev November 2, 2017 20:56
@msftclas
Copy link

msftclas commented Nov 2, 2017

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ staticshock sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

@boyofgreen boyofgreen merged commit b7833ce into pwa-builder:dev Nov 2, 2017
@boyofgreen
Copy link
Contributor

this change is on the preview server now. It does seem to help if you force the site to look for W3C manifest, but currently the test site above (https://newsela.com ) doesn't work with the online generator. I'll keep investigating, but for some reason it doesn't pick up that the manifest file is w3c

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants