Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] undefined icon #4578

Closed
NVD-R opened this issue Dec 11, 2023 · 3 comments
Closed

[BUG] undefined icon #4578

NVD-R opened this issue Dec 11, 2023 · 3 comments

Comments

@NVD-R
Copy link

NVD-R commented Dec 11, 2023

What happened?

The site I was testing is: https://pollint.com/
Error: Failed to download icon https://pollint.com/undefined. Responded with status 500
at ImageHelper.fetchIcon (/app/node_modules/@bubblewrap/core/dist/lib/ImageHelper.js:96:19)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async TwaGenerator.generateIcons (/app/node_modules/@bubblewrap/core/dist/lib/TwaGenerator.js:210:22)
at async Promise.all (index 1)
at async TwaGenerator.generateShortcuts (/app/node_modules/@bubblewrap/core/dist/lib/TwaGenerator.js:242:9)
at async TwaGenerator.createTwaProject (/app/node_modules/@bubblewrap/core/dist/lib/TwaGenerator.js:335:9)
at async BubbleWrapper.generateTwaProject (file:///app/build/bubbleWrapper.js:89:9)
at async BubbleWrapper.generateAppPackage (file:///app/build/bubbleWrapper.js:38:9)
at async createAppPackageWith403Fallback (file:///app/routes/project.js:260:16)
at async createAppPackage (file:///app/routes/project.js:236:16)

How do we reproduce the behavior?

i load my url and android package generator return an undefined word end of my address. so cant download it coz never exists any undefined

What do you expect to happen?

No response

What environment were you using?

i use pwa builder web site

Additional context

No response

@NVD-R NVD-R changed the title [BUG] [BUG] undefined icon Dec 11, 2023
@Jaylyn-Barbee
Copy link
Contributor

I believe this is occurring because in your second shortcut you put an empty list for the icons entry,

"shortcuts": [
       ...,
    {
      "name": "Shortcut Link 2",
      "description": "Shortcut Link 2 Description",
      "url": "/shortcutlink2",
      "icons": [
        []
      ]
    }
]

and its looking for an icon there but can't find it. To fix this, you can just completely remove the icon field since its not required for each shortcut. There are also some other warnings in edge dev tools:

image

Try fixing those warnings, packaging again and you should be good to go.

Copy link
Contributor

This issue has been automatically marked as "no-recent-activity" because it requires author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

Copy link
Contributor

This issue has been automatically closed because it was marked as requiring author feedback but has not had any activity for 7 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants