Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Can't build Windows Package when changing the Classic Version #4732

Closed
v38armageddon opened this issue Jun 3, 2024 · 1 comment
Closed

Comments

@v38armageddon
Copy link

v38armageddon commented Jun 3, 2024

Link to the report card page

https://www.pwabuilder.com/reportcard?site=https://blog.v38armageddon.net

What Store were you trying to package for?

Windows

What is the error message you received?

image

Paste your stack trace below

The site I was testing is: https://blog.v38armageddon.net
We@https://www.pwabuilder.com/code/test-publish-pane.53e393c2.js:13:3036
je@https://www.pwabuilder.com/code/test-publish-pane.53e393c2.js:14:7402
fe@https://www.pwabuilder.com/code/test-publish-pane.53e393c2.js:14:7011
generate@https://www.pwabuilder.com/code/test-publish-pane.53e393c2.js:1833:1129
submitForm@https://www.pwabuilder.com/code/test-publish-pane.53e393c2.js:1914:144
renderFormFooter/<@https://www.pwabuilder.com/code/test-publish-pane.53e393c2.js:1902:76
handleEvent@https://www.pwabuilder.com/code/index.d23e9e02.js:15:6794

What environment were you using?

OS: Archlinux
Browser: Firefox
Version: 126.0.1

Additional context

I was building the package for a new version of my PWA app, I changed the following options when I was trying to build:

  • App Version (changed to 1.0.2)
  • Classic Version (changed to 1.0.2)
  • Icon background color (changed to #000000)

When I changed the Classic version to default value (1.0.0), it worked as expected.

EDIT: I was trying on only one browser, will add update with Microsoft Edge ASAP

@jgw96
Copy link
Contributor

jgw96 commented Jun 4, 2024

Hey @v38armageddon , the classic version ALWAYS has to be lower than the App Version. The tooltip on that form input mentions this, along with our help page on this(https://blog.pwabuilder.com/docs/what-is-a-classic-package/), but the form does not error if the version is wrong. Ill take that on as a separate issue, but yeah, your app packages when the classic version is lower than the app version.

@jgw96 jgw96 closed this as completed Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants