Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Pythonic? #7

Closed
2 tasks done
pwalsh opened this issue Dec 22, 2017 · 1 comment
Closed
2 tasks done

Use Pythonic? #7

pwalsh opened this issue Dec 22, 2017 · 1 comment

Comments

@pwalsh
Copy link
Owner

pwalsh commented Dec 22, 2017

Description

Pythonic is a mature library with a range of utility functions around managing Python processes, setting vars for Python environments, etc.

Tasks

  • Check if Pipenv's way of managing things can leverage Pythonic
  • Identify specific functions to rebase on Pythonic functionality
@pwalsh pwalsh added this to the Melpa release milestone Dec 22, 2017
@pwalsh
Copy link
Owner Author

pwalsh commented Jan 11, 2018

Pythonic is a great library. However, with the way Pipenv is design to work, users mostly have Pipenv installed as a system binary, and use it to manage Python environments. This means we can't really gain anything by using Pythonic, as Pipenv is in a different scope to the Python being used.

I then considered which commands that we support here are executed with the active Python environment, and the two commands are run and open.

run is run via the pipenv executable anyway, so there is no clear need/advantage to use Pythonic.

open has been implemented in emacs lisp, ported from Pipenv's Python code, so that files are opened in the current Emacs session. While this could be done with Pythonic, again the benefit is not clear at this stage of development.

Happy to revisit this, but, recording my thinking here for now, and closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant