Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not able to send address in init request over serial transport #9

Closed
Krolken opened this issue May 18, 2020 · 0 comments
Closed

Not able to send address in init request over serial transport #9

Krolken opened this issue May 18, 2020 · 0 comments
Assignees
@Krolken

Comments

@Krolken
Copy link
Contributor

Krolken commented May 18, 2020

Usually there is no need for an address when initiating communication over the Optical port of a meter, since it is the only meter available.

But the serial transport can also be used för RS485 which allows for multiple meters to be connected to the loop.

So we need support for sending the address over serial transport too. Some manufactures might also enforce and address on the optical port.

Issue raised from discussion in #4
@Krolken Krolken self-assigned this May 18, 2020
@Krolken Krolken mentioned this issue May 18, 2020
Closed
Krolken added a commit that referenced this issue May 18, 2020
@Krolken
fix: Allowed sending of device address on all transport. Raising exce…
85a0784 
…ption if a transport requires address and non is given.

Added typings to transports.py
Fixes #9
Krolken added a commit that referenced this issue May 18, 2020
@Krolken
fix: Allowed sending of device address on all transport. Raising exce…
adc659c 
…ption if a transport requires address and non is given.

Added typings to transports.py
Fixes #9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Krolken Krolken

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Krolken