Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TcpTransport is not creating the socket attribute on __init__ #8

Open
Krolken opened this issue Jan 19, 2021 · 0 comments
Open

TcpTransport is not creating the socket attribute on __init__ #8

Krolken opened this issue Jan 19, 2021 · 0 comments

Comments

@Krolken
Copy link
Contributor

Krolken commented Jan 19, 2021

The attribute for socket is set on connect() which is not very nice structure. An Optional socket variable should be set on init. Probably just a miss since there is typing for the socket in init

relates to #6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Krolken