Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify the static version of the Android framework to avoid build error #198

Closed
wants to merge 1 commit into from
Closed

Specify the static version of the Android framework to avoid build error #198

wants to merge 1 commit into from

Conversation

ivanosire
Copy link

Building android platform this error appear:
"ERROR: In FontFamilyFont, unable to find attribute android:fontVariationSettings
ERROR: In FontFamilyFont, unable to find attribute android:ttcIndex"

With the sign + the android framework used is the new and latest version (28.0.0) but seems incompatible now.

I have fixed writing static version of framework 27.1.0

@ivanosire
Specify the static version of the Android framework to avoid error du…
66b5a95 
…ring building

Building android platform this error appear:
"ERROR: In <declare-styleable> FontFamilyFont, unable to find attribute android:fontVariationSettings                                                                                            
ERROR: In <declare-styleable> FontFamilyFont, unable to find attribute android:ttcIndex"

With the sign + the android framework used is the new and latest version (28.0.0) but seems incompatible now.

I have fixed writing static version of framework 27.1.0
@ghost
Copy link

ghost commented Mar 8, 2018

Noticed the same issue. Any chance to merge that one please?

bbialas
bbialas approved these changes Mar 8, 2018
View reviewed changes
Copy link

@bbialas bbialas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for me, would be great to merge this fix.

@JuanjoPP JuanjoPP mentioned this pull request Mar 8, 2018
Closed
This was referenced Mar 9, 2018
Closed
Closed
@davidgv88
Copy link

Please Merge!

@devjoks devjoks mentioned this pull request Mar 14, 2018
Closed
coderroggie added a commit to coderroggie/cordova-plugin-file-opener2 that referenced this pull request Mar 19, 2018
@coderroggie
Fixing one line issue,
2482f3f 
can be discarded when merged pwlin#198
@zcoffin86
Copy link

Potentially this implementation would be more agreeable, since it will default to not changing the value yet allows you to explicitly set it in the config. Compeat@514dd7d

@shnist
Copy link
Collaborator

shnist commented Dec 11, 2018

hi @ivanosire, thank you for your contribution to this project. We have implemented a solution as per Compeat@514dd7d. This is a more flexible solution and is becoming a fairly standardised pattern across the cordova plugin ecosystem. You can now specify the android support version at installation time:
cordova plugin add cordova-plugin-file-opener2 --variable ANDROID_SUPPORT_VERSION={required version} . This is available in the new 2.1.0 version. This should help resolve your issue and as such we'll be closing this PR.

@shnist shnist closed this Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbialas bbialas bbialas approved these changes

@mateusdemboski mateusdemboski mateusdemboski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ivanosire @davidgv88 @zcoffin86 @shnist @bbialas @mateusdemboski