Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better exception handling for unmet dependencies #1791

Closed
disconnect3d opened this issue Jul 11, 2023 · 0 comments · Fixed by #1853
Closed

Better exception handling for unmet dependencies #1791

disconnect3d opened this issue Jul 11, 2023 · 0 comments · Fixed by #1853
Labels
enhancement For enhancements to existing features good first issue help wanted
Milestone
2024.01

Comments

@disconnect3d
Copy link
Member

Some of our users update Pwndbg only by git pulling the newest version and not re-running setup.sh. If that happens and when we updated our dependencies recently, the user may end up with broken Pwndbg such as (likely) happened in #1790.

We should do the two following things:

  1. When we detect/handle an exception in the pwndbg/exception.py:handle function, we should check the installed dependencies versions against the required ones and if they do not match, we should inform the user to update them.
  2. We may want to display installed dependencies versions within the bugreport command output?
@disconnect3d disconnect3d added enhancement For enhancements to existing features help wanted good first issue labels Jul 11, 2023
@disconnect3d disconnect3d added this to the 2023.10 milestone Jul 25, 2023
kamil-s-solecki added a commit to kamil-s-solecki/pwndbg that referenced this issue Aug 1, 2023
@kamil-s-solecki
Warn user about unmet dependencies (pwndbg#1791)
e4095a7
kamil-s-solecki added a commit to kamil-s-solecki/pwndbg that referenced this issue Aug 1, 2023
@kamil-s-solecki
Warn user about unmet dependencies (pwndbg#1791)
dff7e68
@disconnect3d disconnect3d mentioned this issue Aug 1, 2023
Merged
disconnect3d pushed a commit that referenced this issue Aug 3, 2023
@kamil-s-solecki @disconnect3d
Warn user about unmet dependencies (#1791)
1600e54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement For enhancements to existing features good first issue help wanted
Milestone
2024.01
Development

Successfully merging a pull request may close this issue.

Warn user about unmet dependencies (#1791) kamil-s-solecki/pwndbg
1 participant
@disconnect3d