Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.sh for unknown distros is (partially) broken #551

Closed
chemmi opened this issue Oct 18, 2018 · 1 comment
Closed

setup.sh for unknown distros is (partially) broken #551

chemmi opened this issue Oct 18, 2018 · 1 comment
Labels

Comments

@chemmi
Copy link

chemmi commented Oct 18, 2018

The setup.sh for unknown distros (like kali) is partially broken.
This is due to the fact that it exits too early.
The relevant part is:

pwndbg/setup.sh

Lines 62 to 70 in ab46a79

echo "\"$distro\" is not supported distro. Will search for 'apt' or 'dnf' package managers."
if hash apt; then
install_apt
elif hash dnf; then
install_dnf
else
echo "\"$distro\" is not supported and your distro don't have apt or dnf that we support currently."
fi
exit

This can be fixed by moving =exit= into the else-branch.
One may use =exit 1= instead.

@disconnect3d
Copy link
Member

disconnect3d commented Oct 22, 2018

@chemmi oh, thanks for catching this. Gonna fix it now o/

disconnect3d added a commit to disconnect3d/pwndbg that referenced this issue Oct 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants