New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pwndbg will not display source code when source code has chinese characters #578

Closed
thinkycx opened this Issue Nov 26, 2018 · 4 comments

Comments

Projects
None yet
2 participants
@thinkycx

thinkycx commented Nov 26, 2018

When use directory glibc source in gdb(directory /root/Pwn/glibc/glibc-2.23/malloc), it will display the source code in pwndbg like this:
image

However, when I add Chinese characters in souce code like this, pwndbg will not display it . Is this a bug? Will you fix it?
image

@disconnect3d

This comment has been minimized.

Member

disconnect3d commented Nov 26, 2018

@thinkycx

This comment has been minimized.

thinkycx commented Nov 26, 2018

OK. You can paste the Chinese code below in any code.

// comment 注释:中华人民共和国万岁!

@disconnect3d

@thinkycx thinkycx changed the title from pwndbg will not display source code when source code has chinease characters to pwndbg will not display source code when source code has chinese characters Nov 26, 2018

disconnect3d added a commit to disconnect3d/pwndbg that referenced this issue Nov 27, 2018

Fixes pwndbg#578
It turned out we failed when there were unicode characters in a file.
@disconnect3d

This comment has been minimized.

Member

disconnect3d commented Nov 27, 2018

@thinkycx Please try with latest dev, should be fixed now :)

@thinkycx

This comment has been minimized.

thinkycx commented Nov 27, 2018

It works! Thank you man! Your bug fixing speed is very fast!
image
@disconnect3d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment