Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a smoke test that runs every command to make sure that no errors are thrown. This catches the bug in #1111. The test is currently skipped because it can be flaky, but until we improve it we can at least run it locally while developing.
We run the commands right after
starti
and without passing in any additional args. In the future we can improve this by getting the argparser object for the command and generating some default arguments.We skip running shell commands, as those don't really need testing, and running all of those commands on a user's system could lead to issues. Some of them wait on user input as well, which blocks the test.
A few additional commands needed to be removed, mostly because they either blocked waiting for user input, or just took too long executing every instruction.
errno
andtry_free
seem to be throwing legitimate errors, so for now they're added to this list but should be fixed eventually.Finally, there was a strange issue where
start_binary
itself was throwing exceptions when it was callingstarti
, but the exception was just "Warning:". Some commands randomly threw a few additional exceptions, all seem to be related to accessing memory or setting a breakpoint at address 0x318 (at least on my system). For now I've whitelisted these exceptions, but they should eventually be removed.