Add dev-requirements.txt to Docker image #1115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #1115 +/- ##
=======================================
Coverage 50.13% 50.13%
=======================================
Files 162 162
Lines 19714 19714
Branches 1796 1796
=======================================
Hits 9884 9884
Misses 9496 9496
Partials 334 334 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
I'm not sure about |
|
If we do it, won't mounting volumes over it still work fine? |
|
Yeah. I think we can just move it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building the Docker image currently fails because
./setup.shreferencesdev-requirements.txt, but this was never added to the repo.This PR fixes the issue with the least amount of modification, but I'm wondering if we can just move the
ADD . /pwndbghigher up so that everything in the repo is copied over and we don't have to worry about adding any new files that are needed for setup? Why are we copying individual setup files over in the first place?