-
Notifications
You must be signed in to change notification settings - Fork 857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GDB Refactor [2/N]: move some modules to lib/ #1118
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1118 +/- ##
==========================================
- Coverage 50.23% 50.22% -0.02%
==========================================
Files 168 169 +1
Lines 19867 19871 +4
Branches 1813 1813
==========================================
Hits 9981 9981
- Misses 9550 9554 +4
Partials 336 336
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
What is |
I have no clue, for now my goal is just to move things into the right directories without breaking things. Once that's done, the next step will be to write unit tests, add types, refactor poorly designed code, etc. |
@@ -0,0 +1,28 @@ | |||
from random import choice |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldnt this file be moved instead of added? weird
It is used to enhance display of function arguments of known functions; I think it may have been generated from manpages or some other source |
It uses |
version.py
,which.py
,functions.py
,tips.py
, andfuncparser.py
already didn't have any dependency on GDB, so these could just be copied tolib/
. Also fixed the.gitignore
to not excludepwndbg/lib/
.