Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDB Refactor [6/N]: Move gcc.py into lib/ #1124

Merged
merged 2 commits into from
Sep 5, 2022

Conversation

gsingh93
Copy link
Member

@gsingh93 gsingh93 commented Sep 5, 2022

Moved gcc.py to lib/gcc.py. Added an underscore to the module private functions. which now takes a pwndbg.lib.Arch, and I've added a typehint there to make that clear.

@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2022

Codecov Report

Merging #1124 (7bd4347) into dev (77380eb) will decrease coverage by 0.00%.
The diff coverage is 53.55%.

@@            Coverage Diff             @@
##              dev    #1124      +/-   ##
==========================================
- Coverage   50.23%   50.23%   -0.01%     
==========================================
  Files         168      171       +3     
  Lines       19867    19869       +2     
  Branches     1813     1812       -1     
==========================================
+ Hits         9981     9982       +1     
- Misses       9550     9551       +1     
  Partials      336      336              
Impacted Files Coverage Δ
pwndbg/commands/comments.py 39.47% <0.00%> (ø)
pwndbg/commands/flags.py 37.03% <0.00%> (ø)
pwndbg/commands/procinfo.py 24.61% <0.00%> (ø)
pwndbg/commands/radare2.py 40.47% <0.00%> (ø)
pwndbg/disasm/jump.py 44.44% <0.00%> (ø)
pwndbg/lib/abi.py 93.33% <ø> (ø)
pwndbg/lib/android.py 0.00% <ø> (ø)
pwndbg/lib/funcparser.py 16.66% <ø> (ø)
pwndbg/lib/functions.py 100.00% <ø> (ø)
pwndbg/lib/which.py 52.00% <ø> (ø)
... and 49 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@disconnect3d disconnect3d marked this pull request as ready for review September 5, 2022 18:43
@disconnect3d disconnect3d merged commit eba90ee into pwndbg:dev Sep 5, 2022
@gsingh93 gsingh93 deleted the split-gcc branch September 9, 2022 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants