Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add color for modified registers #1127

Merged
merged 2 commits into from Sep 14, 2022
Merged

add color for modified registers #1127

merged 2 commits into from Sep 14, 2022

Conversation

syheliel
Copy link
Contributor

@syheliel syheliel commented Sep 6, 2022

Fix #1082

@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2022

Codecov Report

Merging #1127 (dec1244) into dev (6d57329) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              dev    #1127      +/-   ##
==========================================
- Coverage   50.23%   50.23%   -0.01%     
==========================================
  Files         171      171              
  Lines       19875    19877       +2     
  Branches     1813     1814       +1     
==========================================
  Hits         9985     9985              
- Misses       9553     9555       +2     
  Partials      337      337              
Impacted Files Coverage Δ
pwndbg/commands/context.py 38.16% <0.00%> (-0.18%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@arcz
Copy link
Contributor

arcz commented Sep 13, 2022

This is how it looks now, I think it's a nice improvement.
Screenshot from 2022-09-13 11-55-11

@disconnect3d
Copy link
Member

disconnect3d commented Sep 13, 2022

@syheliel we should make that color configurable and displayed with the theme command I think. It should also probably color the star symbol?

@disconnect3d disconnect3d merged commit dea9a69 into pwndbg:dev Sep 14, 2022
@disconnect3d
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Better marking of modified registers
4 participants