Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDB Refactor [8/N]: Split memory into lib/ and gdblib/ #1128

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

gsingh93
Copy link
Member

@gsingh93 gsingh93 commented Sep 6, 2022

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2022

Codecov Report

Merging #1128 (22b1ea4) into dev (6d57329) will increase coverage by 0.01%.
The diff coverage is 57.80%.

@@            Coverage Diff             @@
##              dev    #1128      +/-   ##
==========================================
+ Coverage   50.23%   50.24%   +0.01%     
==========================================
  Files         171      172       +1     
  Lines       19875    19879       +4     
  Branches     1813     1813              
==========================================
+ Hits         9985     9989       +4     
  Misses       9553     9553              
  Partials      337      337              
Impacted Files Coverage Δ
pwndbg/commands/comments.py 39.47% <0.00%> (ø)
pwndbg/commands/defcon.py 0.00% <0.00%> (ø)
pwndbg/commands/got.py 37.83% <0.00%> (ø)
pwndbg/commands/leakfind.py 24.46% <0.00%> (ø)
pwndbg/commands/misc.py 81.66% <ø> (ø)
pwndbg/commands/mprotect.py 41.17% <0.00%> (ø)
pwndbg/commands/nearpc.py 86.88% <0.00%> (ø)
pwndbg/commands/peda.py 51.28% <0.00%> (ø)
pwndbg/commands/probeleak.py 25.80% <0.00%> (ø)
pwndbg/commands/search.py 33.96% <0.00%> (ø)
... and 43 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gsingh93
Copy link
Member Author

gsingh93 commented Sep 6, 2022

@disconnect3d the first version of this PR actually broken vmmap, any chance you could write a test for it?

@disconnect3d disconnect3d merged commit 512db53 into pwndbg:dev Sep 6, 2022
@disconnect3d
Copy link
Member

@gsingh93 yes, i will

@gsingh93 gsingh93 deleted the split-memory branch September 9, 2022 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants