Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting/formatting improvements #1138

Merged
merged 3 commits into from
Sep 9, 2022
Merged

Linting/formatting improvements #1138

merged 3 commits into from
Sep 9, 2022

Conversation

gsingh93
Copy link
Member

@gsingh93 gsingh93 commented Sep 9, 2022

  • Run isort, black, and flake8 on the entire root directory
  • Ignore F403 for lines where we do from capstone import * and remove F403 from the ignore list. This way we won't introduce wildcard imports in the future, but don't have to deal with changing any of the capstone code.
  • Remove a bunch of warnings/errors from the ignore list in setup.cfg that required no code changes, and some other minor cleanup.

@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2022

Codecov Report

Merging #1138 (5b4a1d8) into dev (bf37c03) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              dev    #1138   +/-   ##
=======================================
  Coverage   50.24%   50.24%           
=======================================
  Files         172      172           
  Lines       19877    19878    +1     
  Branches     1813     1813           
=======================================
+ Hits         9987     9988    +1     
  Misses       9553     9553           
  Partials      337      337           
Impacted Files Coverage Δ
pytests_collect.py 0.00% <ø> (ø)
gdbinit.py 33.33% <100.00%> (+1.62%) ⬆️
pwndbg/commands/nearpc.py 86.88% <100.00%> (ø)
pwndbg/disasm/__init__.py 54.10% <100.00%> (ø)
pwndbg/disasm/arch.py 66.16% <100.00%> (ø)
pwndbg/disasm/arm.py 32.35% <100.00%> (ø)
pwndbg/disasm/x86.py 62.10% <100.00%> (ø)
pytests_launcher.py 66.66% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gsingh93 gsingh93 mentioned this pull request Sep 9, 2022
@disconnect3d disconnect3d merged commit 544ea0e into pwndbg:dev Sep 9, 2022
@gsingh93 gsingh93 deleted the flake8 branch September 9, 2022 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants