Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show less error when trying to load a non-exist type #1171

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

lebr0nli
Copy link
Contributor

Show less error when trying to load a non-exist type, because seems like the user doesn't need that much information when loading a non-exist type.

Before:

截圖 2022-09-27 下午10 59 50

After:

截圖 2022-09-27 下午11 02 14

@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2022

Codecov Report

Merging #1171 (46babfd) into dev (3b2f779) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              dev    #1171      +/-   ##
==========================================
+ Coverage   52.67%   52.69%   +0.01%     
==========================================
  Files         178      178              
  Lines       20044    20043       -1     
  Branches     1837     1837              
==========================================
+ Hits        10558    10561       +3     
+ Misses       9077     9074       -3     
+ Partials      409      408       -1     
Impacted Files Coverage Δ
pwndbg/gdblib/typeinfo.py 53.84% <0.00%> (+0.51%) ⬆️
pwndbg/stack.py 76.92% <0.00%> (+4.61%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@disconnect3d disconnect3d merged commit 4ad2d76 into pwndbg:dev Sep 27, 2022
@lebr0nli lebr0nli deleted the show-less-typeinfo-error branch October 6, 2022 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants