Fix #1189: fixes patch command's arch=... value #1269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit we passed `pwndbg.gdblib.arch.current` as `arch=...` keyword argument to pwnlib functions like `asm` and `disasm`. Since pwnlib has a concept of "context" that holds variables like currently set architecture or number of bits, this commit starts using those for the `patch` command implementation as we started to set pwnlib context recently in 9e84c18
Codecov Report
@@ Coverage Diff @@
## dev #1269 +/- ##
==========================================
+ Coverage 54.52% 54.80% +0.27%
==========================================
Files 182 182
Lines 20217 20231 +14
Branches 1865 1870 +5
==========================================
+ Hits 11023 11087 +64
+ Misses 8761 8728 -33
+ Partials 433 416 -17
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit we passed
pwndbg.gdblib.arch.currentasarch=...keyword argument to pwnlib functions likeasmanddisasm.Since pwnlib has a concept of "context" that holds variables like currently set architecture or number of bits, this commit starts using those for the
patchcommand implementation as we started to set pwnlib context recently in 9e84c18