Don't catch the error of the heap commands when set exception-* on
#1270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@CptGibbon, could you verify whether this fix works or not? Thanks! |
pwndbg/commands/__init__.py
Outdated
| @@ -276,6 +277,9 @@ def _OnlyWithResolvedHeapSyms(*a, **kw): | |||
| e = lambda s: print(message.error(s)) | |||
| w = lambda s: print(message.warn(s)) | |||
| if pwndbg.heap.current.can_be_resolved(): | |||
| # We don't catch the error for developers, only catch for users. | |||
| if gdb.parameter("exception-verbose") or gdb.parameter("exception-debugger"): | |||
There was a problem hiding this comment.
We should:
- fetch those through pwndbg.config.exception_verbose and pwndbg.config.exception_debugger
- move this to the exception case and re-raise the err
except Exception as err: if ...: raise err
There was a problem hiding this comment.
Ok, I'll fix it with your suggestions!
Codecov Report
@@ Coverage Diff @@
## dev #1270 +/- ##
==========================================
+ Coverage 54.45% 54.79% +0.33%
==========================================
Files 182 182
Lines 20214 20236 +22
Branches 1865 1872 +7
==========================================
+ Hits 11008 11088 +80
+ Misses 8783 8732 -51
+ Partials 423 416 -7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
I'll take a look today, thanks for changing this. |
|
This does indeed print out a backtrace when |
disconnect3d
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the nightmare when debugging the heap commands (#1242 (comment))